cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...
Date Wed, 07 Sep 2016 03:35:24 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1578#discussion_r77755754
  
    --- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
    @@ -988,6 +1016,21 @@ public boolean addDhcpEntry(final Network network, final NicProfile
nic, final V
             return result;
         }
     
    +    protected boolean deleteDhcpSupportForSubnet(Network network, Network.Service service)
throws ResourceUnavailableException {
    +        if (canHandle(network, service)) {
    +            final List<DomainRouterVO> routers = _routerDao.listByNetworkAndRole(network.getId(),
Role.VIRTUAL_ROUTER);
    +            if (routers == null || routers.size() == 0) {
    +                throw new ResourceUnavailableException("Can't find at least one router!",
DataCenter.class, network.getDataCenterId());
    +            }
    +            try {
    +                return _routerMgr.removeDhcpSupportForSubnet(network, routers);
    +            } catch (final ResourceUnavailableException e) {
    +                s_logger.debug("Router resource unavailable ");
    --- End diff --
    
    Why not log this information to ``ERROR`` or ``WARN``?  Please add context information
about the ``routers`` and ``network`` to help operational debugging.  Finally, please add
the exception to the log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message