cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...
Date Wed, 07 Sep 2016 03:28:52 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1578#discussion_r77755434
  
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
    @@ -431,6 +448,17 @@ private Answer executeRequest(ShutDownVpcVspCommand cmd) {
             }
         }
     
    +    private Answer executeRequest(ShutDownVspCommand cmd) {
    +        try {
    +            isNuageVspElementLoaded();
    +            _nuageVspElementClient.shutdownNetwork(cmd.getNetwork(), cmd.getDhcpOptions());
    +            return new Answer(cmd, true, "Shutdown VPC " + cmd.getNetwork().getUuid()+
" on Nuage VSD " + _hostName);
    +        } catch (ConfigurationException e) {
    +            s_logger.error("Failure during " + cmd + " on Nuage VSD " + _hostName, e);
    --- End diff --
    
    Please add ``cmd.getDhcpOptions`` to the log message to assist with operational debugging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message