cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <>
Subject [GitHub] cloudstack pull request #1578: CLOUDSTACK-9401 : Support for Internal DNS in...
Date Wed, 07 Sep 2016 03:13:30 GMT
Github user jburwell commented on a diff in the pull request:
    --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/
    @@ -19,25 +19,29 @@
    +import net.nuage.vsp.acs.client.api.model.VspDhcpVMOption;
     import net.nuage.vsp.acs.client.api.model.VspNetwork;
     import net.nuage.vsp.acs.client.api.model.VspNic;
     import net.nuage.vsp.acs.client.api.model.VspStaticNat;
     import net.nuage.vsp.acs.client.api.model.VspVm;
     public class ReserveVmInterfaceVspCommand extends Command {
         private final VspNetwork _network;
         private final VspVm _vm;
         private final VspNic _nic;
         private final VspStaticNat _staticNat;
    +    private final  VspDhcpVMOption _dhcpOption;
    --- End diff --
    ``private final VspNetwork`` and ``private final VspNetwork _network`` appear many of
these command classes.  Would it make it sense to consolidate these commonalities in a VSP
abstract command class?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message