cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1671: Adding support for cross-cluster storage migr...
Date Tue, 06 Sep 2016 13:38:09 GMT
Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1671#discussion_r77635261
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xen610/XenServer610MigrateWithStorageReceiveCommandWrapper.java
---
    @@ -56,7 +55,7 @@
         public Answer execute(final MigrateWithStorageReceiveCommand command, final XenServer610Resource
xenServer610Resource) {
             final Connection connection = xenServer610Resource.getConnection();
             final VirtualMachineTO vmSpec = command.getVirtualMachine();
    -        final List<Pair<VolumeTO, StorageFilerTO>> volumeToFiler = command.getVolumeToFiler();
    +        final List<Pair<VolumeTO, String>> volumeToStorageUuid = command.getVolumeToStorageUuid();
    --- End diff --
    
    I checked where this was being accessed from throughout the codebase and all hypervisors
should be OK with this change.
    
    They all seemed to only care about a string UUID in the StorageFilerTO object.
    
    This PR is only for XenMotion and vMotion. This PR does not enabled cross-cluster storage
migration (for managed storage) on any other hypervisor(s) in CloudStack.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message