cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1671: Adding support for cross-cluster storage migr...
Date Tue, 06 Sep 2016 13:15:29 GMT
Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1671#discussion_r77631355
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCreateStoragePoolCommandWrapper.java
---
    @@ -39,20 +41,35 @@
         public Answer execute(final CreateStoragePoolCommand command, final CitrixResourceBase
citrixResourceBase) {
             final Connection conn = citrixResourceBase.getConnection();
             final StorageFilerTO pool = command.getPool();
    +
             try {
    -            if (pool.getType() == StoragePoolType.NetworkFilesystem) {
    -                citrixResourceBase.getNfsSR(conn, Long.toString(pool.getId()), pool.getUuid(),
pool.getHost(), pool.getPath(), pool.toString());
    -            } else if (pool.getType() == StoragePoolType.IscsiLUN) {
    -                citrixResourceBase.getIscsiSR(conn, pool.getUuid(), pool.getHost(), pool.getPath(),
null, null, false);
    -            } else if (pool.getType() == StoragePoolType.PreSetup) {
    -            } else {
    -                return new Answer(command, false, "The pool type: " + pool.getType().name()
+ " is not supported.");
    +            if (command.getCreateDatastore()) {
    --- End diff --
    
    can we come here for non-managed storage?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message