cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper a...
Date Fri, 02 Sep 2016 02:31:21 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1660#discussion_r77285299
  
    --- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
    @@ -196,6 +201,16 @@ public static void scpTo(String host, int port, String user, File
pemKeyFile, St
     
                 String result = sbResult.toString();
     
    +            if (StringUtils.isBlank(result)) {
    +                try {
    +                    result = IOUtils.toString(stdout, UTF8);
    --- End diff --
    
    Rather than use a homegrown string constant, pass ``StandardCharsets.UTF_8`` instead.
 An additional benefit is that it is a ``Charset`` instance which provides greater type safety.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message