cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From murali-reddy <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1666: CLOUDSTACK-9480: Egress Firewall: Incorrect u...
Date Thu, 01 Sep 2016 06:22:15 GMT
Github user murali-reddy commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1666#discussion_r77119259
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
    @@ -145,40 +145,41 @@ def add_rule(self, cidr):
                 logging.debug("Current ACL IP direction is ==> %s", self.direction)
                 if self.direction == 'egress':
                     self.fw.append(["filter", "", " -A FW_OUTBOUND -j FW_EGRESS_RULES"])
    +                fwr = " -I FW_EGRESS_RULES"
    +
    +                #In case we have a default rule (accept all or drop all), we have to
evaluate the action again.
    +                if self.rule['cidr'] == ['0.0.0.0/0']:
    --- End diff --
    
    If-else block does exactly that logic. If rule has CIDR 0.0.0.0/0 then rule action is
set to that of default egress policy in the network offering. If rule has a CIDR other than
0.0.0.0/0 then reverse action (as that of default egress policy in the network offering) is
set for the rule


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message