Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: rafaelweingartner <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1593-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1593-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring
Content-Type: text/plain
Message-Id: <20160811174423.0F67BE03E8@git1-us-west.apache.org>
Date: Thu, 11 Aug 2016 17:44:23 +0000 (UTC)
archived-at: Thu, 11 Aug 2016 17:44:25 -0000

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1593#discussion_r74468365
  
    --- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java ---
    @@ -72,7 +72,9 @@ protected boolean checkItemCountByPstmt(CheckCase checkCase) throws SQLException
             try (PreparedStatement pstmt = conn.prepareStatement(checkCase.sqlTemplate)) {
                 if(checkCase.checkId) {
                     pstmt.setInt(1, lastId);
    -                pstmt.setInt(2, maxId);
    +                if (maxId > 0) {
    +                    pstmt.setInt(2, maxId);
    --- End diff --
    
    Is this set the setting of the parameter for the SQL excerpt at line 216?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---