Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1545-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1545-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1545: CLOUDSTACK-8715: Add channel to Instances for...
Content-Type: text/plain
Message-Id: <20160810140625.27D76E03E8@git1-us-west.apache.org>
Date: Wed, 10 Aug 2016 14:06:25 +0000 (UTC)
archived-at: Wed, 10 Aug 2016 14:06:27 -0000

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1545#discussion_r74250378
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ---
    @@ -1209,25 +1209,95 @@ public String toString() {
             }
         }
     
    -    public static class VirtioSerialDef {
    -        private final String _name;
    -        private String _path;
    +    public static class ChannelDef {
    +        enum ChannelType {
    +            UNIX("unix"), SERIAL("serial");
    +            String type;
     
    -        public VirtioSerialDef(String name, String path) {
    -            _name = name;
    -            _path = path;
    +            ChannelType(String type) {
    +                this.type = type;
    +            }
    +
    +            @Override
    +            public String toString() {
    +                return this.type;
    +            }
    +        }
    +
    +        enum ChannelState {
    +            DISCONNECTED("disconnected"), CONNECTED("connected");
    +            String type;
    +
    +            ChannelState(String type) {
    +                this.type = type;
    +            }
    +
    +            @Override
    +            public String toString() {
    +                return type;
    +            }
    +        }
    +
    +        private String name;
    +        private String path;
    +        private ChannelType type;
    +        private ChannelState state;
    --- End diff --
    
    These attributes are not modified by the class.  Why not declare them as ``final``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---