cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1669: Make CloudStack JSP-free
Date Tue, 30 Aug 2016 14:40:33 GMT
GitHub user rhtyd opened a pull request:

    https://github.com/apache/cloudstack/pull/1669

    Make CloudStack JSP-free

    CLOUDSTACK-9842: Make UI JSP Free
        
        We use some JSP file just for translation of strings in the UI. This is
        achievable purely in JavaScript. This removes those JSPs, simplifies
        translation usage and workflow (purely JS based).
        
    CLOUDSTACK-9842: Add compiled translations as JS files
        
        Uses the messages.properties to javascript file compiler to export current
        translation file into a pure JS files.
        
    @milamberspace can our translation workflow/infra be changed to translate the JS files
instead of the messages.properties file?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack no-jsp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1669
    
----
commit 72a4b298b4442d7a41e301daa8f89749d9154a8c
Author: Rohit Yadav <rohit.yadav@shapeblue.com>
Date:   2016-08-30T10:25:00Z

    CLOUDSTACK-9842: Make UI JSP Free
    
    We use some JSP file just for translation of strings in the UI. This is
    achievable purely in JavaScript. This removes those JSPs, simplifies
    translation usage and workflow (purely JS based).
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

commit 92d98ac5142ee69930642bedf587e0fa957539a3
Author: Rohit Yadav <rohit.yadav@shapeblue.com>
Date:   2016-08-30T14:30:21Z

    CLOUDSTACK-9842: Add compiled translations as JS files
    
    Uses the messages.properties to javascript file compiler to export current
    translation file into a pure JS files.
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message