cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ProjectMoon <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1623: Enable/disable static NAT associates only rel...
Date Tue, 02 Aug 2016 14:33:35 GMT
GitHub user ProjectMoon opened a pull request:

    https://github.com/apache/cloudstack/pull/1623

    Enable/disable static NAT associates only relevant IPs.

    New version of #1450, opened against the 4.8 branch.
    
    **Original Description**
    This pull request fixes a concurrency issue when disabling static NAT on a bunch of IPs
simultaneously. Under the old behavior, executing multiple disable requests would result in
invalid IP associations being sent to the virtual router. This commit changes the behavior
to apply an IP association for only the IP being added/released, which means that it is impossible
for the virtual router to receive invalid data.
    
    This was tested against a virtual router running on KVM and VMware. It would be nice to
have some input how this change could affect redundant routers and other static NAT providers.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greenqloud/cloudstack pr-static-nat-concurrency-fix-4.8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1623
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message