cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...
Date Wed, 31 Aug 2016 21:50:04 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1600#discussion_r77080328
  
    --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
    @@ -92,7 +90,34 @@
     
         @Override
         public SnapshotInfo backupSnapshot(SnapshotInfo snapshotInfo) {
    -        return snapshotInfo;
    +
    +        if (!snapshotInfo.getLocationType().equals(Snapshot.LocationType.SECONDARY))
{
    --- End diff --
    
    Since Enum values are guaranteed to be singletons, the `==` is that same as `equals`.
 By changing this check to be ``snapshotInfo.getLocationType() != Snapshot.LocationType.SECONDARY``,
a potential NPE is avoided and the code is more straightforward.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message