cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1635: CLOUDSTACK-9451
Date Mon, 29 Aug 2016 08:17:14 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1635#discussion_r76569173
  
    --- Diff: engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
    @@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, @BeanParam DeploymentPlan
plan, E
         boolean stop(String caller) throws ResourceUnavailableException, CloudException;
     
         /**
    +     * Stop the virtual machine, optionally force
    +     *
    +     */
    +    boolean stop(String caller, boolean forced) throws ResourceUnavailableException,
CloudException;
    --- End diff --
    
    @jburwell the `forced` flag has always existed, the `stopVirtualMachine` API accepts this
and the query layer too has a method with this signature (https://github.com/apache/cloudstack/pull/1635/files#diff-0a1cd9df984252594918eec5acfed08cR3850)
but it does not honour or pass this flag to the layers below, so effectively stopVM API with/without
the `forced` flag has the same effect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message