cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1635: CLOUDSTACK-9451
Date Mon, 29 Aug 2016 01:37:24 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1635#discussion_r76544594
  
    --- Diff: engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
    @@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse, @BeanParam DeploymentPlan
plan, E
         boolean stop(String caller) throws ResourceUnavailableException, CloudException;
     
         /**
    +     * Stop the virtual machine, optionally force
    +     *
    +     */
    +    boolean stop(String caller, boolean forced) throws ResourceUnavailableException,
CloudException;
    --- End diff --
    
    [Flag arguments](http://martinfowler.com/bliki/FlagArgument.html) are a nasty code smell/anti-pattern.
 Please consider changing method to something more descriptive with a flag argument such as
``forceStop(String caller)``.  The contrasting version of the method already exists on the
interface so it would be a compatible change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message