cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vincentbernat <>
Subject [GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...
Date Thu, 25 Aug 2016 20:44:37 GMT
Github user vincentbernat commented on a diff in the pull request:
    --- Diff: packaging/systemd/cloudstack-agent.default ---
    @@ -0,0 +1,24 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +if [ ! -f "$JAVA_HOME"/bin/java ] ; then
    +    JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
    --- End diff --
    Are you sure this will work with systemd? On Ubuntu, the best it could do is to keep `JAVA_HOME=/usr/lib/jvm/jre`
which is not valid on Ubuntu. Maybe, it would be easier to push that inside the ExecStart
(and equivalent in init.d):
    if [ -n "$JAVA_HOME" ]; then
      export JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
    Or, keeping it for RHEL in the default file but using in ExecStart:
    [ -d "$JAVA_HOME" ] || export JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message