cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rhtyd <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...
Date Thu, 25 Aug 2016 08:41:52 GMT
Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1647#discussion_r76202771
  
    --- Diff: debian/rules ---
    @@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 1)
     SYSCONFDIR = "/etc"
     DESTDIR = "debian/tmp"
     
    -ifeq ($(shell lsb_release -sr), 14.04)
    -        SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" -Vjdk:Depends="openjdk-7-jdk"
-Vinit:"Depends:jsvc"
    -else
    -        SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" -Vjdk:Depends="openjdk-8-jdk"
-Vinit:"Depends:systemd"
    -endif
    -
    --- End diff --
    
    @vincentbernat that's right, but if we use that then we'll need to build/host/publish
two version of the deb repository, depending on whether the deb pkgs were built of Ubuntu
14.04 or 16.04+. I think the current is still a good compromise, I can add new dependency
options to allow users to use oracle jre/jdk.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message