cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...
Date Wed, 24 Aug 2016 20:07:45 GMT
Github user nvazquez commented on the issue:

    https://github.com/apache/cloudstack/pull/1605
  
    Thanks @rafaelweingartner for your review! I've been working on it and pushed changes
based on your comments!
    The only thing I need to mention is that actually I can't remove `throws Exception` from
`setNewVRamSizeVmVideoCard` method, as `getAllDeviceList` method throws Exception and that's
the reason for catch block on `configureVideoCard`. Do you agree with this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message