cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vincentbernat <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...
Date Wed, 24 Aug 2016 11:26:06 GMT
Github user vincentbernat commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1647#discussion_r76039128
  
    --- Diff: debian/rules ---
    @@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 1)
     SYSCONFDIR = "/etc"
     DESTDIR = "debian/tmp"
     
    -ifeq ($(shell lsb_release -sr), 14.04)
    -        SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" -Vjdk:Depends="openjdk-7-jdk"
-Vinit:"Depends:jsvc"
    -else
    -        SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" -Vjdk:Depends="openjdk-8-jdk"
-Vinit:"Depends:systemd"
    -endif
    -
    --- End diff --
    
    I would have kept something like that but using init-system-helpers instead of systemd.
It is not unheard of for people to not install recommends. However, init-system-helpers is
likely to be installed on the target system already (since everything that comes with a systemd
unit pulls it). So, it's a bit nitpicking.
    
    About Java, you can change the dependency to:
    
    ```
    default-jre-headless (>= 1:1.8) | java8-runtime-headless | java8-runtime
    ```
    
    This would enable people to use Oracle JRE instead. Most packages for non-OpenJDK JRE
are providing `java8-runtime-headless` or `java8-runtime`. For JDK, this would be:
    
    ```
    default-jdk-headless (>= 1:1.8) | java8-sdk | java8-jdk
    ```
    
    The normal virtual package is `java8-sdk` but some unofficial packages are using `java8-jdk`
instead.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message