cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1639: CLOUDSTACK-9453: WIP : Marvin optimizations a...
Date Mon, 22 Aug 2016 02:16:52 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1639#discussion_r75610946
  
    --- Diff: tools/marvin/marvin/lib/common.py ---
    @@ -334,13 +335,57 @@ def get_template(
             return FAILED
     
         for template in list_templatesout:
    -        if template.isready and template.templatetype == template_type:
    +        if template.isready and template.templatetype == template_type and template.name.startswith('CentOS'):
                 return template
         '''
         Return default first template, if no template matched
         '''
         return list_templatesout[0]
     
    +def get_template_macchinina(
    --- End diff --
    
    This function and the ``get_template`` function seem very similar.  The only difference
appears to be that  ``get_template`` function is checking for ``CentOS`` and ``get_template_macchinia``
is checking for ``macchinia``.  Please refactor these functions to remove the duplication.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message