cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marcaurele <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stop...
Date Thu, 18 Aug 2016 06:06:29 GMT
Github user marcaurele commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1640#discussion_r75252604
  
    --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
    @@ -497,7 +498,7 @@ protected Long restart(final HaWorkVO work) {
     
                     boolean fenced = false;
                     if (alive == null) {
    -                    s_logger.debug("Fencing off VM that we don't know the state of");
    +                    s_logger.debug("Fencing off VM " + vm + " that we don't know the
state of");
    --- End diff --
    
    Turning all of those log debug lines without a `if` statement to lambda expressions when
we require Java8 would be easier if there're not wrapped within a `if`:
    ```
    s_logger.debug(() -> "Fencing off VM " + vm + " that we don't know the state of");
    ```
    with
    ```
    default void debug(Supplier<String> stringSupplier) {
        if (isDebugEnabled()) {
            debug(stringSupplier.get());
        }
    }
    ```
    The concatenation will be only done when debug is enabled.
    
    You're right, I turn it to `warn`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message