cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1611: marvin: deploy clusters in separate threads
Date Wed, 17 Aug 2016 06:59:20 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1611#discussion_r75071072
  
    --- Diff: tools/marvin/marvin/deployDataCenter.py ---
    @@ -224,6 +225,15 @@ def createClusters(self, clusters, zoneId, podId, vmwareDc=None):
                                                    podId,
                                                    clusterId)
     
    +            threads = []
    +            for cluster in clusters:
    +                t = threading.Thread(target=createCluster, args=(cluster,))
    +                t.start()
    +                threads.append(t)
    +
    +            for t in threads:
    +                t.join(1800)
    --- End diff --
    
    Instead of hardcoding, better to set it based on host count in the cluster. Also consider
that waitForHost() can wait upto 60 secs.
    
    If one t.join() throws what happens to the other threads. Also will __cleanAndExit() behave
consistently if there are exceptions in multiple threads.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message