cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...
Date Fri, 12 Aug 2016 13:51:04 GMT
Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1542
  
    I understand the need to create a test. And I agree that it deserves a test. What I meant
was the following.
    
    IMHO, you could simply remove the final keyword of the variable declaration. Sometimes
in the ACS code, I have seen people using some design/ways of coding without having a good
and well-thought explanation for them (the use of final is one good example). For instance,
variables “VmwareEnableNestedVirtualization” and “VmwareEnableNestedVirtualizationPerVM”
are only used in the “VMwareGuru” class. They do not need to be either static or public.
Moreover, there is no need for those variables to be final. 
    
    If those variables were protected (only), it would be much easier to write test cases.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message