cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...
Date Thu, 11 Aug 2016 16:50:45 GMT
Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1542
  
    @nvazquez  the code is great now.
    
    I have just a concern about that hack to change the field declared as final.
    In my opinion, the final there does not bring benefits. So, I believe it can be removed.

    I have seen people using final a lot, but I think that final should be used only when
we have 100% certainty that it is needed; otherwise, it complicates our lives when writing
test cases or while extending some method/class.
    
    What do you think?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message