cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...
Date Thu, 11 Aug 2016 14:21:57 GMT
Github user nvazquez commented on the issue:

    https://github.com/apache/cloudstack/pull/1542
  
    @rafaelweingartner thanks a lot for your help as always!
    
    I refactored based on your comments. I really liked your review, especially your refactor
on `shouldEnableNestedVirtualization`, it really simplifies method's understanding. I also
included all your suggestions on method's names and in-order verification.
    
    I had to make some changes on `VmwareGuruTest` using reflection to include mocks in configuration
keys variables on `VmwareGuru`. What do you think about this solution?
    
    Thanks again for taking the time to review this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message