cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1624: Fixes regarding VOLUME_DELETE events resultin...
Date Wed, 10 Aug 2016 19:31:32 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1624#discussion_r74313796
  
    --- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
    @@ -231,6 +253,73 @@ public void cleanup() {
             CallContext.unregister();
         }
     
    +    public UsageEventUtils setupUsageUtils() {
    +        _usageEventDao = new MockUsageEventDao();
    +        UsageEventUtils utils = new UsageEventUtils();
    +
    +        Map<String, String> usageUtilsFields = new HashMap<String, String>();
    +        usageUtilsFields.put("usageEventDao", "_usageEventDao");
    +        usageUtilsFields.put("accountDao", "_accountDao");
    +        usageUtilsFields.put("dcDao", "_dcDao");
    +        usageUtilsFields.put("configDao", "_configDao");
    --- End diff --
    
    Why not declare this map as a static constant?  It would shorten this method and make
it easier to understand.   Also, consider using the ``ImmutableMap`` type for the type of
the constant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message