cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1545: CLOUDSTACK-8715: Add channel to Instances for...
Date Wed, 10 Aug 2016 13:53:11 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1545#discussion_r74247733
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
    @@ -768,6 +770,12 @@ public boolean configure(final String name, final Map<String,
Object> params) th
                 _localStoragePath = "/var/lib/libvirt/images/";
             }
     
    +        /* Directory to use for Qemu sockets like for the Qemu Guest Agent */
    +        _qemuSocketsPath = (String)params.get("qemu.sockets.path");
    +        if (Strings.isNullOrEmpty(_qemuSocketsPath)) {
    --- End diff --
    
    One issue we have found with ``Strings.isNullOrEmpty`` is that it does do a ``trim`` when
checking for an empty string.  Therefore, a string containing one or more strings is considered
non-empty.  Therefore, consider using ``StringUtils.isNoneBlank`` if a string containing only
whitespace would be a a problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message