cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nvazquez <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...
Date Tue, 02 Aug 2016 13:44:55 GMT
Github user nvazquez commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1615#discussion_r73156984
  
    --- Diff: engine/schema/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDetailVO.java
---
    @@ -23,61 +23,61 @@
     import javax.persistence.Id;
     import javax.persistence.Table;
     
    -import org.apache.cloudstack.api.InternalIdentity;
    +import org.apache.cloudstack.api.ResourceDetail;
     
     @Entity
     @Table(name = "image_store_details")
    -public class ImageStoreDetailVO implements InternalIdentity {
    +public class ImageStoreDetailVO implements ResourceDetail {
         @Id
         @GeneratedValue(strategy = GenerationType.IDENTITY)
         @Column(name = "id")
         long id;
     
         @Column(name = "store_id")
    -    long storeId;
    +    long resourceId;
     
         @Column(name = "name")
         String name;
     
         @Column(name = "value")
         String value;
     
    +    @Column(name = "display")
    --- End diff --
    
    We added it to make it consistent with `ResourceDetail` as we made `ImageStoreDetailVO`
implement `ResourceDetail`, which has the method `isDisplay`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message