Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: leprechau <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1608-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1608-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request #1608: Cleanup RBD contexts after exceptions to prev...
Content-Type: text/plain
Message-Id: <20160711192544.4DFA6DFFF8@git1-us-west.apache.org>
Date: Mon, 11 Jul 2016 19:25:44 +0000 (UTC)
archived-at: Mon, 11 Jul 2016 19:25:46 -0000

GitHub user leprechau reopened a pull request:

    https://github.com/apache/cloudstack/pull/1608

    Cleanup RBD contexts after exceptions to prevent potential agent crash

    We noticed that when an exception occurs within the cleanup loop inside
    the deletePhysicalDisk routine that the previously allocated contexts
    are not cleaned up.  This seemed to cause an eventual crash of the host
    agent after multiple exceptions within the loop.
    
    In addition to ensuring the contexts are always freed we also improved
    the logging when exceptions do occur to include the actual return code
    from the underlying library in deletePhysicalDisk and deleteSnapshot.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/myENA/cloudstack upstream/context-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1608.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1608
    
----
commit 44491448e3811cfcebe5c3aeee72ba7a01948cda
Author: Aaron Hurt <ahurt@anbcs.com>
Date:   2016-07-09T03:57:06Z

    Cleanup rbd contexts and improve exception logging
    
    We noticed that when an exception occurs within the cleanup loop inside
    the deletePhysicalDisk routine that the previously allocated contexts
    are not cleaned up.  This seemed to cause an eventual crash of the host
    agent after multiple exceptions within the loop.
    
    In addition to ensuring the contexts are always freed we also improved
    the logging when exceptions do occur to include the actual return code
    from the underlying library in deletePhysicalDisk and deleteSnapshot.

commit c8fce3ff31c1437681f1c2b32864eb2d34b66be5
Author: Aaron Hurt <ahurt@ena.com>
Date:   2016-07-11T15:49:43Z

    improve logging readability

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---