Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 11F09200B40 for ; Fri, 1 Jul 2016 18:15:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 10970160A61; Fri, 1 Jul 2016 16:15:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4EAAE160A4D for ; Fri, 1 Jul 2016 18:15:27 +0200 (CEST) Received: (qmail 82754 invoked by uid 500); 1 Jul 2016 16:15:26 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 82738 invoked by uid 99); 1 Jul 2016 16:15:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jul 2016 16:15:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 71EB2E009D; Fri, 1 Jul 2016 16:15:25 +0000 (UTC) From: remibergsma To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou... Content-Type: text/plain Message-Id: <20160701161525.71EB2E009D@git1-us-west.apache.org> Date: Fri, 1 Jul 2016 16:15:25 +0000 (UTC) archived-at: Fri, 01 Jul 2016 16:15:28 -0000 Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1580 PEP8 recommends max line length of 79, why bump it to 150? That doesn't help in readability IMO. And yes, I know many other tests are crappy formatted too. But since you state it's PEP8 complaint I suggest to do it fully :-) Does that test take >7 hours? Wow. Do you have any metrics on why that takes so long? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---