cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From romain-dartigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1603: Vrouter fixes pylint
Date Tue, 05 Jul 2016 09:16:58 GMT
GitHub user romain-dartigues opened a pull request:

    https://github.com/apache/cloudstack/pull/1603

    Vrouter fixes pylint

    In my dreams, all Python code pass through pylint and must validate before a merge.
    
    This merge request is becoming quite big, maybe too much; I'd like to have the owners
opinion.
    
    It follow the previous pull requests:
    * #1575
      + PCextreme/cloudstack/pull/2
        - #1547


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/romain-dartigues/cloudstack vrouter-fixes-pylint

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1603.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1603
    
----
commit ffee6146e28013676b5eca200492324c1022682b
Author: Romain Dartigues <romain.dartigues@gmail.com>
Date:   2016-06-01T11:58:07Z

    systemvm: make pylint happy
    
    Mostly removing unused modules, but also defined some missing variables.
    
     40  'X' imported but unused
      9  'from X import *' used; unable to detect undefined names
      9  local variable 'X' is assigned to but never used
      1  redefinition of unused 'X' from line Y
      1  undefined name 'X'

commit 77a53d06107822fd69b940a0769d00cbbeef81b2
Author: Romain Dartigues <romain.dartigues@gmail.com>
Date:   2016-07-04T12:00:06Z

    rebase in progress; onto 1f9bf93
    
    You are currently rebasing branch 'vrouter-fixes-pylint' on '1f9bf93'

commit 8c6372c1c21062bfbd876dc751a94108e49c2e20
Author: Romain Dartigues <romain.dartigues@gmail.com>
Date:   2016-06-02T06:52:00Z

    systemvm: pylint conformance work in progress
    
    Few more code conformity (long lines and such).
    
    Rebased after merge e4ba640.
    
    Your code has been rated at 7.41/10 (previous run: 5.04/10, +2.37)
    
    Raw metrics
    -----------
    
    +----------+-------+------+---------+-----------+
    |type      |number |%     |previous |difference |
    +==========+=======+======+=========+===========+
    |code      |4179   |62.09 |4161     |+18.00     |
    +----------+-------+------+---------+-----------+
    |docstring |385    |5.72  |367      |+18.00     |
    +----------+-------+------+---------+-----------+
    |comment   |1122   |16.67 |1087     |+35.00     |
    +----------+-------+------+---------+-----------+
    |empty     |1045   |15.53 |1042     |+3.00      |
    +----------+-------+------+---------+-----------+
    
    Messages by category
    --------------------
    
    +-----------+-------+---------+-----------+
    |type       |number |previous |difference |
    +===========+=======+=========+===========+
    |convention |866    |1095     |-229.00    |
    +-----------+-------+---------+-----------+
    |refactor   |34     |55       |-21.00     |
    +-----------+-------+---------+-----------+
    |warning    |76     |699      |-623.00    |
    +-----------+-------+---------+-----------+
    |error      |3      |13       |-10.00     |
    +-----------+-------+---------+-----------+

commit 38a36b5da0bcda58d670a135040739b52569a827
Author: Romain Dartigues <romain.dartigues@gmail.com>
Date:   2016-07-05T06:40:41Z

    refactor monitorServices.py, lots of changes
    
    Could be simplified by using the stdlib modules logging and json.
    
    Messages by category
    --------------------
    
    +------------+--------+----------+------------+
    | type       | number | previous | difference |
    +============+========+==========+============+
    | convention |      5 |      115 |    -110.00 |
    +------------+--------+----------+------------+
    | refactor   |      1 |        4 |      -3.00 |
    +------------+--------+----------+------------+
    | warning    |      6 |       39 |     -33.00 |
    +------------+--------+----------+------------+
    | error      |      0 |        0 |    =       |
    +------------+--------+----------+------------+
    
    Global evaluation
    -----------------
    Your code has been rated at 9.40/10 (previous run: 3.01/10, +6.39)

commit c558c767e5b400a14fbdaca5c345abc48372adec
Author: Romain Dartigues <romain.dartigues@gmail.com>
Date:   2016-07-05T06:42:19Z

    systemvm: pylint conformance work in progress
    
    Raw metrics
    -----------
    
    +----------+-------+------+---------+-----------+
    |type      |number |%     |previous |difference |
    +==========+=======+======+=========+===========+
    |code      |  4426 |62.50 |    4179 |   +247.00 |
    +----------+-------+------+---------+-----------+
    |docstring |   496 | 7.00 |     385 |   +111.00 |
    +----------+-------+------+---------+-----------+
    |comment   |  1130 |15.96 |    1122 |     +8.00 |
    +----------+-------+------+---------+-----------+
    |empty     |  1030 |14.54 |    1045 |    -15.00 |
    +----------+-------+------+---------+-----------+
    
    Duplication
    -----------
    
    +-------------------------+------+---------+-----------+
    |                         |now   |previous |difference |
    +=========================+======+=========+===========+
    |nb duplicated lines      |22    |64       |-42.00     |
    +-------------------------+------+---------+-----------+
    |percent duplicated lines |0.313 |0.959    |-0.65      |
    +-------------------------+------+---------+-----------+
    
    Messages by category
    --------------------
    
    +-----------+-------+---------+-----------+
    |type       |number |previous |difference |
    +===========+=======+=========+===========+
    |convention |   613 |     866 |   -253.00 |
    +-----------+-------+---------+-----------+
    |refactor   |    26 |      34 |     -8.00 |
    +-----------+-------+---------+-----------+
    |warning    |    42 |      76 |    -34.00 |
    +-----------+-------+---------+-----------+
    |error      |     4 |       3 |     +1.00 |
    +-----------+-------+---------+-----------+
    
    Global evaluation
    -----------------
    Your code has been rated at 8.15/10 (previous run: 7.41/10, +0.74)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message