cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pdube <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1609: [CLOUDSTACK-9430] Added fix for adding/editin...
Date Tue, 12 Jul 2016 13:33:49 GMT
GitHub user pdube reopened a pull request:

    https://github.com/apache/cloudstack/pull/1609

    [CLOUDSTACK-9430] Added fix for adding/editing Network ACL rule ordering

    BUG: https://issues.apache.org/jira/browse/CLOUDSTACK-9430
    
    The issue occurred because all of the ACL rules get inserted before the old ones. Then,
the cleanup deletes the duplicate rows, and leaves any new rule in front of the old ones.
    
    Here is an example with a simplified iptables view for ACL
    Ex: adding a rule 4
    before add:
    1,2,3
    
    during add:
    1',2',3',4',1,2,3
    
    after add:
    4',1,2,3
    
    After fix:
    before add:
    1,2,3
    
    during add:
    1,2,3,1',2',3',4'
    
    after add:
    1',2',3',4'


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pdube/cloudstack network-acl-add-order

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1609.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1609
    
----
commit 6dd6ef0c9a30f128657de22fa8b6ea8ab5daa133
Author: Patrick Dube <pdube@cloudops.com>
Date:   2016-07-11T19:12:41Z

    Added fix for adding/editing Network ACL rule ordering

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message