cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1608: Cleanup RBD contexts after exceptions to prev...
Date Mon, 11 Jul 2016 08:14:42 GMT
Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1608#discussion_r70216966
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
---
    @@ -1325,6 +1328,8 @@ public Answer deleteSnapshot(final DeleteCommand cmd) {
                         image.snapRemove(snapshotName);
                         s_logger.info("Snapshot " + snap_full_name + " successfully removed
from " +
                                 primaryPool.getType().toString() + "  pool.");
    +                } catch (RbdException e) {
    +                    s_logger.error(e.toString() + " - " + ErrorCode.getErrorMessage(e.getReturnValue()));
    --- End diff --
    
    Should we maybe include a bit more? Like:
    
    <pre>Failed to remove snapshot X, due to error: Y</pre>
    
    Now we just dump a Exception into the logs which might not always tell a user where it
came from.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message