cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sateesh-chodapuneedi <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...
Date Wed, 06 Jul 2016 05:36:44 GMT
Github user sateesh-chodapuneedi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1605#discussion_r69677503
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
    @@ -2015,19 +2016,20 @@ protected StartAnswer execute(StartCommand cmd) {
         }
     
         /**
    -     * Sets video card memory to the one provided in detail svga.vramSize (if provided).
    +     * Sets video card memory to the one provided in detail svga.vramSize (if provided)
on {@code vmConfigSpec}.
          * 64MB was always set before.
          * Size must be in KB.
          * @param vmMo virtual machine mo
          * @param vmSpec virtual machine specs
    +     * @param vmConfigSpec virtual machine config spec
          */
    -    protected void postVideoCardMemoryConfigBeforeStart(VirtualMachineMO vmMo, VirtualMachineTO
vmSpec) {
    +    protected void videoCardMemoryConfig(VirtualMachineMO vmMo, VirtualMachineTO vmSpec,
VirtualMachineConfigSpec vmConfigSpec) {
             String paramVRamSize = "svga.vramSize";
    --- End diff --
    
    👍 Thanks @nvazquez for this PR. It indeed reduces additional API calls.
    I'd suggest few minor changes though.
    Please move this string constant "svga.vramSize" to VmDetailConstants which is place holder
for VM detail constants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message