cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From The-Loeki <...@git.apache.org>
Subject [GitHub] cloudstack issue #1603: Vrouter fixes pylint
Date Tue, 05 Jul 2016 16:03:37 GMT
Github user The-Loeki commented on the issue:

    https://github.com/apache/cloudstack/pull/1603
  
    Hi :) sorry I was unable to process your request to merge your PR with mine, as you can
probably tell by now this would've oversized & muddied both PR's ;)
    Depending on the uptake of the CS team here I'm quite willing to help you with it, because
as I mentioned IMHO this should've been done from the start on.
    
    So the `.format()` syntax is less compatible as you mention. It is however only incompatible
with long-deprecated Python versions and CS SysVM's are compatible so that's not really an
issue.
    While of course it is a matter of personal taste, the official message from Python pplz
however is that `.format()` is intended to replace the `%s` formatting: https://docs.python.org/2/library/stdtypes.html#str.format
, which is why I and the other OSS projects I work on prefer it.
    
    The logging one is an excellent remark though, wading through the docs I notice that they've
added the `.format()` syntax as per 3.2: https://docs.python.org/3/howto/logging-cookbook.html#use-of-alternative-formatting-styles
 
    
    I'm not sure from the top of my head which version the SysVM's are using, but if it's
not Py3 it oughta be (here comes the next big-ass PR ;) ) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message