cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From romain-dartigues <...@git.apache.org>
Subject [GitHub] cloudstack issue #1603: Vrouter fixes pylint
Date Tue, 05 Jul 2016 14:22:36 GMT
Github user romain-dartigues commented on the issue:

    https://github.com/apache/cloudstack/pull/1603
  
    Hi @The-Loeki, and thank you for your prompt comment!
    
    For your side notes:
    
    * this is mostly a preference, I don't care what you use but here are my argument for
the `%s`:
    
      + more portable than the `.format()` (Python 2.4 → Python 3)
      + coherent with `logging` methods; ie: `logging.debug('foo {}', 'bar')` = `TypeError`,
the correct syntax is `logging.debug('foo %s', 'bar')`
    
    * I also prefer single quotes, especially because double quotes are never "nessary" (in
Python single and double are equivalent)
    
    I didn't want to change "too much" (well, I think my patch is already too much; we should
focus on documentation after that); if I did replace all double quote with single, for example,
I would break `git blame` way too much for my taste.
    
    But I'm totally willing to put some more work for conformity, if there is a will for it
upstream ;^)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message