cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From syed <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1602: CLOUDSTACK-9422: Granular 'vmware.create.full...
Date Mon, 04 Jul 2016 19:05:08 GMT
Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1602#discussion_r69486019
  
    --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
    @@ -1353,6 +1363,20 @@ public void prepare(VirtualMachineProfile vm, DeployDestination
dest) throws Sto
                 disk.setDetails(getDetails(volumeInfo, dataStore));
     
                 vm.addDisk(disk);
    +
    +            // If hypervisor is vSphere, check for clone type setting.
    +            if (vm.getHypervisorType().equals(HypervisorType.VMware)) {
    --- End diff --
    
    So the idea is, instead of creating a clone which is linked to a parent, we would create
a full clone of the disk. I can see this being useful when you don't want to have the overhead
of nested reads/writes. Am I correct?
    
    So there are reasons to use a `linked` clone as pointed out by @serg38  and there are
reasons to use a full clone as well. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message