cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...
Date Fri, 17 Jun 2016 20:39:38 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1594#discussion_r67572107
  
    --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
    @@ -2086,6 +2089,18 @@ public boolean expunge(UserVmVO vm, long callerUserId, Account
caller) {
             }
         }
     
    +    /**
    +     * Release network resources, it was done on vm stop previously.
    +     * @param id vm id
    +     * @throws ConcurrentOperationException
    +     * @throws ResourceUnavailableException
    +     */
    +    private void releaseNetworkResourcesOnExpunge(long id) throws ConcurrentOperationException,
ResourceUnavailableException {
    +        final VMInstanceVO vmInstance = _vmDao.findById(id);
    --- End diff --
    
    It is possible for ``_vmDao.findById`` to return ``null``.  Please handling for that case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message