cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...
Date Fri, 17 Jun 2016 20:38:40 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1594#discussion_r67571985
  
    --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
    @@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO vm, final boolean cleanUpEvenIfUnabl
             }
     
             try {
    -            _networkMgr.release(profile, cleanUpEvenIfUnableToStop);
    -            s_logger.debug("Successfully released network resources for the vm " + vm);
    +            s_logger.debug("Not releasing network resources until expunge command is
sent");
    +            //_networkMgr.release(profile, cleanUpEvenIfUnableToStop);
    +            //s_logger.debug("Successfully released network resources for the vm " +
vm);
    --- End diff --
    
    Please remove commented code.  It is cruft, and git history allows us to see how code
has changed overtime.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message