cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jburwell <...@git.apache.org>
Subject [GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring
Date Fri, 17 Jun 2016 19:34:45 GMT
Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1593#discussion_r67563826
  
    --- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java ---
    @@ -72,7 +72,9 @@ protected boolean checkItemCountByPstmt(CheckCase checkCase) throws
SQLException
             try (PreparedStatement pstmt = conn.prepareStatement(checkCase.sqlTemplate))
{
                 if(checkCase.checkId) {
                     pstmt.setInt(1, lastId);
    -                pstmt.setInt(2, maxId);
    +                if (maxId > 0) {
    +                    pstmt.setInt(2, maxId);
    +                }
    --- End diff --
    
    This ``if`` creates a circumstance where the second parameter of the ``PreparedStatement``
will not be set.  In this circumstance, an exception will be thrown.  Therefore, this code
either always set the value or throw an ``IllegalStateException`` explaining the condition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message