cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <...@git.apache.org>
Subject [GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...
Date Thu, 09 Jun 2016 23:23:16 GMT
Github user swill commented on the issue:

    https://github.com/apache/cloudstack/pull/1547
  
    I ran the same network tests I mentioned above against master and I had the following
results.
    
    ```
    Tests Run: 24
      Skipped: 0
       Failed: 8
       Errors: 2
     Duration: 2h 35m 53s
    ```
    
    All of the errors were the same on `master`, but in addition it also had a failure on
this test:
    ```
    FAIL: Test authorize ingress rule
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/data/git/cs2/cloudstack/test/integration/component/test_security_groups.py",
line 459, in test_01_authorizeIngressRule
        (self.virtual_machine.ipaddress, e)
    AssertionError: SSH Access failed for 192.168.22.221: SSH connection has Failed. Waited
600s. Error is SSH Connection Failed
    ----------------------------------------------------------------------
    Additional details in: /tmp/MarvinLogs/test_routers_ZEOUOD/results.txt
    ```
    
    I am not sure if this PR fixed this issue or if it is just an intermittent issue, but
this shows that this PR did not introduce any new issues into master (according to these unverified
tests).
    
    Given that this fixes issues in basic networking and does not appear to introduce any
new issues, I am inclined to add it to the 4.9 release.  
    
    @wido, @remibergsma and @DaanHoogland do you guys agree with this decision?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message