cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swill <...@git.apache.org>
Subject [GitHub] cloudstack issue #1563: CLOUDSTACK-9389:[automation]updating test_routers_ne...
Date Thu, 09 Jun 2016 12:05:31 GMT
Github user swill commented on the issue:

    https://github.com/apache/cloudstack/pull/1563
  
    This assumes that people know how to work with the test data and that they understand
that "this random template needs X format and this other one will need Y format".  This is
too much to ask without guidance, especially as we try to improve the automatability of the
testing.  
    
    The regex idea is not a perfect solution, but would allow for us to handle more template
types with a single entry.  Ideally we would be able to specify the expected values for this
type of thing in an OS specific way so the tested (and verified) values for each OS can live
in the test data. It would probably need a default that is used if the current OS does not
have a match. 
    
    My main problem with this is that it will, by default,  break this test for everyone using
bubble to automate their testing. Maybe we leave the old default test value in place, and
people who are testing with other OSs can now override manually. 
    
    What do you think? Sorry, I don't mean to be combative here, but this is a good opertunity
for us to review the way we handle OS specific test data. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message