Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 353B42009C6 for ; Tue, 31 May 2016 12:41:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 34373160A01; Tue, 31 May 2016 10:41:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 74CCF160A43 for ; Tue, 31 May 2016 12:41:18 +0200 (CEST) Received: (qmail 31584 invoked by uid 500); 31 May 2016 10:41:17 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 31359 invoked by uid 99); 31 May 2016 10:41:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2016 10:41:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1E41EDFB74; Tue, 31 May 2016 10:41:17 +0000 (UTC) From: rhtyd To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ... Content-Type: text/plain Message-Id: <20160531104117.1E41EDFB74@git1-us-west.apache.org> Date: Tue, 31 May 2016 10:41:17 +0000 (UTC) archived-at: Tue, 31 May 2016 10:41:19 -0000 Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65158988 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import com.cloud.utils.exception.CloudRuntimeException; +import org.apache.log4j.Logger; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +public class DriverLoader { + + private static final Logger s_logger = Logger.getLogger(DriverLoader.class.getName()); --- End diff -- avoid using s_, just use LOGGER, or LOG. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---