Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AEF5C2009D9 for ; Thu, 19 May 2016 10:38:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AD991160A04; Thu, 19 May 2016 08:38:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EBE6C160A00 for ; Thu, 19 May 2016 10:38:08 +0200 (CEST) Received: (qmail 39008 invoked by uid 500); 19 May 2016 08:38:07 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 38997 invoked by uid 99); 19 May 2016 08:38:07 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 May 2016 08:38:07 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8611FDFBA1; Thu, 19 May 2016 08:38:07 +0000 (UTC) From: wido To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: dynamic-roles: packaging improvements Content-Type: text/plain Message-Id: <20160519083807.8611FDFBA1@git1-us-west.apache.org> Date: Thu, 19 May 2016 08:38:07 +0000 (UTC) archived-at: Thu, 19 May 2016 08:38:09 -0000 Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220262092 Ok, so this PR seems to fix multiple things. I would LGTM on the packaging fixes as well as the Python part. The MySQL thing I'm not sure about. I wouldn't say that it is a problem perse, but we all know what one line of code can do (err, I mean break...) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---