Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: GabrielBrascher <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1518-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1518-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...
Content-Type: text/plain
Message-Id: <20160514200416.507AEDFB04@git1-us-west.apache.org>
Date: Sat, 14 May 2016 20:04:16 +0000 (UTC)
archived-at: Sat, 14 May 2016 20:04:18 -0000

Github user GabrielBrascher commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1518#discussion_r63281246
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java ---
    @@ -303,6 +305,7 @@
         protected String _password;
         protected String _guid;
         protected String _vCenterAddress;
    +    protected Integer _storageNfsVersion;
    --- End diff --
    
    There has been a discussion about slowly remove the underscore at the beginning of variables. Could you please remove it? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---