Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1403-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1403-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Content-Type: text/plain
Message-Id: <20160511174136.638E6DFC6C@git1-us-west.apache.org>
Date: Wed, 11 May 2016 17:41:36 +0000 (UTC)
archived-at: Wed, 11 May 2016 17:41:38 -0000

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r62892495
  
    --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
    @@ -144,6 +145,8 @@
         @Inject
         SnapshotDataStoreDao _snapshotStoreDao;
         @Inject
    +    private DataStoreManager _dataStoreMgr;
    --- End diff --
    
    there is already a dataStoreMgr. why are two needed? (also underscore names are against naming convention)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---