Return-Path: <dev-return-94379-archive-asf-public=cust-asf.ponee.io@cloudstack.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 5511F2004CA
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 11 May 2016 19:05:55 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 53C08160A14; Wed, 11 May 2016 17:05:55 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 9D266160A09
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 11 May 2016 19:05:54 +0200 (CEST)
Received: (qmail 50592 invoked by uid 500); 11 May 2016 17:05:53 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 50581 invoked by uid 99); 11 May 2016 17:05:53 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 17:05:53 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 511E2DFC6C; Wed, 11 May 2016 17:05:53 +0000 (UTC)
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1403-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1403-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Content-Type: text/plain
Message-Id: <20160511170553.511E2DFC6C@git1-us-west.apache.org>
Date: Wed, 11 May 2016 17:05:53 +0000 (UTC)
archived-at: Wed, 11 May 2016 17:05:55 -0000

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r62886608
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ---
    @@ -2351,17 +2376,52 @@ public SR getIscsiSR(final Connection conn, final String srNameLabel, final Stri
                             throw new CloudRuntimeException(msg, e);
                         }
                     }
    +
                     deviceConfig.put("SCSIid", scsiid);
     
    -                final String result = SR.probe(conn, host, deviceConfig, type, smConfig);
    +                String result = SR.probe(conn, host, deviceConfig, type, smConfig);
    +
                     String pooluuid = null;
    +
                     if (result.indexOf("<UUID>") != -1) {
                         pooluuid = result.substring(result.indexOf("<UUID>") + 6, result.indexOf("</UUID>")).trim();
                     }
     
                     if (pooluuid == null || pooluuid.length() != 36) {
                         sr = SR.create(conn, host, deviceConfig, new Long(0), srNameLabel, srNameLabel, type, "user", true, smConfig);
    -                } else {
    +                }
    +                else {
    +                    if (resignature) {
    --- End diff --
    
    maybe a method createIfResignable()? thsi file is a blob of blobs, let's get to reducing the problem called CitrixResourceBase


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---