Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 487B72004CA for ; Wed, 11 May 2016 18:18:34 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 472CB160A14; Wed, 11 May 2016 16:18:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 903BE160A09 for ; Wed, 11 May 2016 18:18:33 +0200 (CEST) Received: (qmail 83864 invoked by uid 500); 11 May 2016 16:18:32 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 83848 invoked by uid 99); 11 May 2016 16:18:32 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 16:18:32 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3DD5DDFC55; Wed, 11 May 2016 16:18:32 +0000 (UTC) From: DaanHoogland To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot... Content-Type: text/plain Message-Id: <20160511161832.3DD5DDFC55@git1-us-west.apache.org> Date: Wed, 11 May 2016 16:18:32 +0000 (UTC) archived-at: Wed, 11 May 2016 16:18:34 -0000 Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62878912 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -72,8 +77,10 @@ private static final Logger s_logger = Logger.getLogger(StorageSystemSnapshotStrategy.class); @Inject private AgentManager _agentMgr; + @Inject private ClusterDao _clusterDao; @Inject private DataStoreManager _dataStoreMgr; @Inject private HostDao _hostDao; + @Inject private HostDetailsDao _hostDetailsDao; --- End diff -- warning for not used --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---