Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1403-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1403-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...
Content-Type: text/plain
Message-Id: <20160511151526.1CAA6DFC77@git1-us-west.apache.org>
Date: Wed, 11 May 2016 15:15:26 +0000 (UTC)
archived-at: Wed, 11 May 2016 15:15:28 -0000

Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1403#discussion_r62867309
  
    --- Diff: engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreInfo.java ---
    @@ -36,6 +36,7 @@
         static final String CHAP_INITIATOR_SECRET = "chapInitiatorSecret";
         static final String CHAP_TARGET_USERNAME = "chapTargetUsername";
         static final String CHAP_TARGET_SECRET = "chapTargetSecret";
    +    static final String REMOVE_AFTER_COPY = "removeAfterCopy";
    --- End diff --
    
    not lethal but these strings seem to warrant an enum as well, do they?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---