Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-1371-cloudstack@git.apache.org>
In-Reply-To: <git-pr-1371-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...
Content-Type: text/plain
Message-Id: <20160511015312.194A0E78BE@git1-us-west.apache.org>
Date: Wed, 11 May 2016 01:53:12 +0000 (UTC)
archived-at: Wed, 11 May 2016 01:53:14 -0000

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62782162
  
    --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
    @@ -529,14 +545,14 @@ private boolean findCapabilityForService(final Map serviceCapabilitystList, fina
             if (serviceCapabilitystList != null && !serviceCapabilitystList.isEmpty()) {
                 final Iterator iter = serviceCapabilitystList.values().iterator();
                 while (iter.hasNext()) {
    -                final HashMap<String, String> currentCapabilityMap = (HashMap<String, String>) iter.next();
    +                final HashMap<String, String> currentCapabilityMap = (HashMap<String, String>)iter.next();
    --- End diff --
    
    Please type to the ``Map`` interface rather than ``HashMap`` to reduce coupling.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---