Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: syed <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-816-cloudstack@git.apache.org>
In-Reply-To: <git-pr-816-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Notify listeners when a host has been add...
Content-Type: text/plain
Message-Id: <20160509144459.21207DFBAB@git1-us-west.apache.org>
Date: Mon,  9 May 2016 14:44:59 +0000 (UTC)
archived-at: Mon, 09 May 2016 14:45:06 -0000

Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/816#discussion_r62509977
  
    --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java ---
    @@ -65,22 +94,182 @@ public boolean hostConnect(long hostId, long storagePoolId) {
                 storagePoolHostDao.persist(storagePoolHost);
             }
     
    -        // just want to send the ModifyStoragePoolCommand for KVM
    -        if (host.getHypervisorType() != HypervisorType.KVM) {
    -            return true;
    +        if (host.getHypervisorType().equals(HypervisorType.XenServer)) {
    +            handleXenServer(host.getClusterId(), host.getId(), storagePoolId);
    +        }
    +        else if (host.getHypervisorType().equals(HypervisorType.KVM)) {
    +            handleKVM(hostId, storagePoolId);
    +        }
    +
    +        return true;
    +    }
    +
    +    @Override
    +    public boolean hostDisconnected(long hostId, long storagePoolId) {
    +        StoragePoolHostVO storagePoolHost = storagePoolHostDao.findByPoolHost(storagePoolId, hostId);
    +
    +        if (storagePoolHost != null) {
    +            storagePoolHostDao.deleteStoragePoolHostDetails(hostId, storagePoolId);
    +        }
    +
    +        return true;
    +    }
    +
    +    @Override
    +    public boolean hostAboutToBeRemoved(long hostId) {
    +        HostVO host = _hostDao.findById(hostId);
    +
    +        handleVMware(host, false);
    --- End diff --
    
    Can this be done in `hostRemoved` ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---